[Commented On] D8783: storageutil: allow modern hash sizes for fileids

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Wed Aug 26 16:24:41 UTC 2020


marmoute added a comment.


  This look good overall. I wonder how much the tuple creation and lookup cost and if we should have two explicite test instead.
  
  This question leads me to wonder if we should not simply have the store advertise the size of the hash it use and strictly test against that. What do you think ?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8783/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8783

To: joerg.sonnenberger, #hg-reviewers
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200826/399ff1e0/attachment-0002.html>


More information about the Mercurial-patches mailing list