[Updated] D8928: worker: don't expose readinto() on _blockingreader since pickle is picky

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Wed Aug 26 16:35:07 UTC 2020


martinvonz added inline comments.
martinvonz marked an inline comment as done.

INLINE COMMENTS

> marmoute wrote in worker.py:94
> This seems like a correct, but unrelated change. Should we extract it in its own changesets?

It's not needed without this patch (see commit message), and justifying without this patch is harder, so I prefer to leave it in this patch.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8928/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8928

To: martinvonz, #hg-reviewers, marmoute
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200826/97fa341d/attachment-0002.html>


More information about the Mercurial-patches mailing list