[Commented On] D8938: run-tests: refactor filtering logic for --retest flag

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Wed Aug 26 18:05:56 UTC 2020


marmoute added inline comments.

INLINE COMMENTS

> khanchi97 wrote in run-tests.py:3252
> This is to make test name for "multiple dimensions" testcases (not much familiar with multiple dimensions though).  See https://www.mercurial-scm.org/repo/hg-committed/file/tip/tests/test-run-tests.t#l959
> 
> Maybe I should consider adding a comment before this line?

I missed the fact we could have multiple "cases". You should probably document it.

And add a tes for this case with `--retest`

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8938/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8938

To: khanchi97, #hg-reviewers, marmoute
Cc: marmoute, pulkit, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200826/51a0df06/attachment-0002.html>


More information about the Mercurial-patches mailing list