[Commented On] D8949: rewriteutil: also consider pending obsoletes when updating hashes in messages

[marmoute (Pierre-Yves David)]

marmoute added a comment.
marmoute accepted this revision.


  Sounds fine, Maybe mention `pending` semantic and intended usage into the function docstring?

INLINE COMMENTS

> rewriteutil.py:52
>          if not ctx.obsolete():
> -            continue
> -
> -        successors = obsutil.successorssets(repo, ctx.node(), cache=cache)
> +            successors = pending.get(fullnode, None)
> +            if successors is None:

nits: `None` is already the default for `.get(key)`

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8949/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8949

To: mharbison72, #hg-reviewers, marmoute
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200826/3682d9a0/attachment-0002.html>