[Updated] D8959: hg-core: define a `DebugData` `Operation`

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Fri Aug 28 12:46:48 UTC 2020


This revision now requires changes to proceed.
Alphare added inline comments.
Alphare requested changes to this revision.

INLINE COMMENTS

> debugdata.rs:35
> +
> +impl std::error::Error for DebugDataError {}
> +

Let's not implement `Error`, it requires a UTF8 description and has other issues.

> debugdata.rs:37
> +
> +impl fmt::Display for DebugDataError {
> +    fn fmt(&self, _f: &mut fmt::Formatter<'_>) -> fmt::Result {

Same for `Display`

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8959/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8959

To: acezar, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200828/f0b20a85/attachment-0002.html>


More information about the Mercurial-patches mailing list