[Changed Subscribers] D8960: rhg: add a `DebugData` `Command` to prepare the `rhg debugdata` subcommand
Alphare (Raphaël Gomès)
phabricator at mercurial-scm.org
Fri Aug 28 12:54:08 UTC 2020
Alphare added inline comments.
INLINE COMMENTS
> debugdata.rs:43
> + kind: CommandErrorKind::Abort(Some(
> + [b"abort: ", err.to_string().as_bytes(), b"\n"].concat(),
> + )),
`to_string()` is unnecessary.
> debugdata.rs:43
> + kind: CommandErrorKind::Abort(Some(
> + [b"abort: ", err.to_string().as_bytes(), b"\n"].concat(),
> + )),
Also, didn't we discuss having some sort of `utf8_to_local` method that did nothing for now but allowed encapsulation for future support of different locales?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8960/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8960
To: acezar, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200828/36daa56a/attachment-0002.html>
More information about the Mercurial-patches
mailing list