[Updated] D8524: phabricator: add .arcconfig to help messages and comments (issue6331)

[mharbison72 (Matt Harbison)]

This revision now requires changes to proceed.
mharbison72 added a comment.
mharbison72 requested changes to this revision.


  The documentation updates look good to me, but there are still some code changes that were probably not intentional, and the commit message probably needs an update.
  
  > It gets a little messy when uploading partial patches to code that I am patching
  
  Are you simply amending your local commit and reposting it with phabsend?  If not, I'm not sure what the state of it will be if someone imports it to land it.
  
  > Ok, the problem I was running into with the exthelper stuff is that it wasn't getting invoked, and it wasn't getting invoked because my extension did not set its uisetup at all. So the fix is very similar to the above: from hgext.phabricator import uisetup
  
  I've got a similar extension that wraps the command itself and changes all reviewers to blocking reviewers (so that the first accept doesn't drop it out of everybody else's queue).  I don't understand importing `hgext.phabricator.uisetup` though.  You should have this somewhere near the top of your extension like `phabricator.py` does
  
    eh = exthelper.exthelper()
    ...
    uisetup = eh.finaluisetup
  
  The underlying machinery simply looks for attributes on the module like `uisetup()`, `reposetup()`, etc, and calls them if present.  And yeah, I get confused all the time about the differences between these hooks too.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8524/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8524

To: sfink, mharbison72, marmoute
Cc: marmoute, Kwan, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200829/79fcbe8e/attachment-0002.html>