[Commented On] D8958: hg-core: Add a limited read only `revlog` implementation

[acezar (Antoine Cezar)]

acezar added inline comments.

INLINE COMMENTS

> Alphare wrote in revlog.rs:95
> I was merely commenting on the fact that you used a `Vec<_>` and not a `&[_]`, which is really nitpicking since it's a private function that forced no cloning or allocation in the first place, but it's always a good idea to take by reference if that's not more effort.
> 
> Regarding your idea about generic `RevlogEntry` vs *log-specific structures, I too don't have enough perspective to be sure how the implementation should go. Maybe it should be a trait, for example. But let's stick with your idea of figuring things out along the way, that sounds good.

I have misunderstood your comment. I thought it was about `-> Vec<u8>`.

> Alphare wrote in revlog.rs:101
> https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=3b54c1e0470590b54e89d6d347bba6f2
> 
> This should work, if not we can talk about it on IRC so as to not pollute the review with debugging.

It does not work because of the `std::borrow::Cow`.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8958/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8958

To: acezar, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200831/8ef8c50a/attachment-0002.html>