[Changed Subscribers] D9462: chgserver: catch RepoError while loading configuration
mharbison72 (Matt Harbison)
phabricator at mercurial-scm.org
Tue Dec 1 19:03:13 UTC 2020
mharbison72 added inline comments.
INLINE COMMENTS
> chgserver.py:513
> + # configuration
> + self.ui.error(_(b"abort: %s\n") % inst)
> + if inst.hint:
Does the error need `stringutil.forcebytestr()`? I see it in some places but not others, and am not sure the difference. Maybe hg errors don't need it but python exceptions do?
> chgserver.py:515
> + if inst.hint:
> + self.ui.error(_("(%s)\n") % inst.hint)
> + errorraised = True
Needs bytes? (I can fix in flight, I just wanted to confirm).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D9462/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D9462
To: pulkit, #hg-reviewers, marmoute
Cc: mharbison72, marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20201201/f56924c8/attachment-0001.html>
More information about the Mercurial-patches
mailing list