[Updated] D9450: cext: isolate hash size in the revlog handling in a single place

[martinvonz (Martin von Zweigbergk)]

This revision now requires changes to proceed.
martinvonz added inline comments.
martinvonz requested changes to this revision.

INLINE COMMENTS

> revlog.c:1500
> +	if (!hex && nodelen == self->nodelen && node[0] == '\0' &&
> +	    node[1] == '\0' && memcmp(node, nullid, self->nodelen) == 0)
>  		return -1;

Is this extra `node[1] == '\0'` check intentional? It seems unrelated to me. Can you move it to a separate patch?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9450/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9450

To: joerg.sonnenberger, #hg-reviewers, Alphare, martinvonz
Cc: martinvonz, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20201216/ac6126cb/attachment.html>