[Updated] D9554: diff: add --from and --to flags as clearer alternative to -r -r

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu Dec 10 04:54:08 UTC 2020


martinvonz added a comment.


  > I haven't followed all of the UI enhancement discussions; it looks familiar, so is this something planned for other commands (e.g. status, extdiff)?
  
  I had not planned to do it for those, but it would make sense (expect that I think it's another mistake that `hg status` can work on anything but the working copy to start with).

INLINE COMMENTS

> mharbison72 wrote in commands.py:2548-2549
> Should this be something like `scmutil.revrange()`, and then raise an InputError here if what was passed isn't `len() == 1` for each?  It would avoid awkwardness like `--from a::b`.

I wish revingle() made that check but since it doesn't, I think it's better than we still use revingle()'s current behavior for consistency. See example with date() revset in the next patch.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9554/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9554

To: martinvonz, #hg-reviewers
Cc: mharbison72, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20201210/f7d74806/attachment-0002.html>


More information about the Mercurial-patches mailing list