[Commented On] D8480: bundle: optional advisory obsolescence parts

[joerg.sonnenberger (Joerg Sonnenberger)]

joerg.sonnenberger added inline comments.

INLINE COMMENTS

> marmoute wrote in commands.py:1652-1663
> I find this harder to read than the previous code. We got a 12 ling one-liner instead of simple `if cond: \n logic`

I blame black and the long names for that, mostly. It's a dict literal spread over 9 lines for 3 entries. No logic even. I don't want move the strings to a variable to make shorter, because it also makes it less grepable.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8480/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8480

To: joerg.sonnenberger, #hg-reviewers, marmoute, baymax
Cc: durin42, marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20201216/6400b1c8/attachment-0002.html>