[Commented On] D9450: cext: isolate hash size in the revlog handling in a single place

[martinvonz (Martin von Zweigbergk)]

martinvonz added inline comments.

INLINE COMMENTS

> joerg.sonnenberger wrote in revlog.c:1500
> Yes, it is intentional. I've added it because unlike before, the memcmp will not be inlined automatically and therefore the original check does come with a much higher false positive rate. The explicit check is for free on all architectures with unaligned memory access.

Okay, makes sense. That was far from obvious (to me anyway) and could probably have been mentioned in the commit message.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9450/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9450

To: joerg.sonnenberger, #hg-reviewers, Alphare, martinvonz
Cc: martinvonz, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20201216/0136df13/attachment-0002.html>