[Changed Subscribers] D9577: upgrade: move `printrequirements()` to UpgradeOperation class
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Tue Dec 22 08:34:13 UTC 2020
marmoute added inline comments.
INLINE COMMENTS
> actions.py:574-585
> + # requirements which will be added by the operation
> + self.added_requirements = (
> + self.new_requirements - self.current_requirements
> + )
> + # requirements which will be removed by the operation
> + self.removed_requirements = (
> + self.current_requirements - self.new_requirements
should we put this into `_` attribute to avoid clutting the "public" API of the object ? (and maybe compute them within the `print_requirements` method?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D9577/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D9577
To: pulkit, #hg-reviewers
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20201222/4bc62e28/attachment-0002.html>
More information about the Mercurial-patches
mailing list