[Commented On] D9616: upgrade: rename actions to upgrade_actions
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Wed Dec 30 09:59:46 UTC 2020
pulkit added a comment.
In D9616#145570 <https://phab.mercurial-scm.org/D9616#145570>, @marmoute wrote:
> okay I see D9618 <https://phab.mercurial-scm.org/D9618> now. This makes me a bit confuse about the function in the current diff. What is that function about ? do we only use it for display purpose and not behavior purpose ? If so, what do we display during downgrade ?
As the diff shows, right now we use it for a couple of purposes:
1. Display purpose
2. Checking whether some optimizations exist or not
During downgrade, we display the set of removed requirements.
A good part of the current upgrade code is coupled with diffing old and new requirements which I am planning to refactor in upcoming patches.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D9616/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D9616
To: pulkit, #hg-reviewers
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20201230/3c84335d/attachment-0002.html>
More information about the Mercurial-patches
mailing list