[Commented On] D8771: localrepo: only use BOOKMARKS_IN_STORE_REQUIRMENT is we have a store

[martinvonz (Martin von Zweigbergk)]

martinvonz added inline comments.

INLINE COMMENTS

> localrepo.py:3328-3333
> +            ui.warn(
> +                _(
> +                    b'dropping %s requirement as store is not enabled'
> +                    % bookmarks.BOOKMARKS_IN_STORE_REQUIREMENT
> +                )
> +            )

This should probably be rewritten in a language that makes sense to the user (or do we tell them what repo requirements are somewhere?). Perhaps something like "ignoring enabled format.bookmarks-in-store config because it incompatible with the disabled format.usestore config".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8771/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8771

To: pulkit, #hg-reviewers
Cc: martinvonz, marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20200801/3ad1bbdc/attachment.html>