[Updated] D8721: scmutil: allowing different files to be prefetched per revision

[mjacob (Manuel Jacob)]

mjacob added inline comments.

INLINE COMMENTS

> rdamazio wrote in __init__.py:1124
> Ugh:
> 
>   Skipped test-check-pyflakes.t: missing feature: Pyflakes python linter
> 
> To be fair, the full list is this:
> 
>   Skipped test-casecollision-merge.t: missing feature: case insensitive file system
>   Skipped test-casefolding.t: missing feature: case insensitive file system
>   Skipped test-check-clang-format.t: missing feature: clang-format C code formatter
>   Skipped test-check-format.t: missing feature: the black formatter for python
>   Skipped test-check-jshint.t: missing feature: JSHint static code analysis tool
>   Skipped test-check-pyflakes.t: missing feature: Pyflakes python linter
>   Skipped test-check-pylint.t: missing feature: Pylint python linter
>   Skipped test-check-rust-format.t: missing feature: rustfmt tool
>   Skipped test-chg.t: missing feature: running with chg
>   Skipped test-convert-baz.t: missing feature: GNU Arch baz client
>   Skipped test-convert-bzr-114.t: missing feature: Canonical's Bazaar client >= 1.14
>   Skipped test-convert-bzr-directories.t: missing feature: Canonical's Bazaar client
>   Skipped test-convert-bzr-ghosts.t: missing feature: Canonical's Bazaar client
>   Skipped test-convert-bzr-merges.t: missing feature: Canonical's Bazaar client
>   Skipped test-convert-bzr-treeroot.t: missing feature: Canonical's Bazaar client
>   Skipped test-convert-bzr.t: missing feature: Canonical's Bazaar client
>   Skipped test-convert-darcs.t: missing feature: darcs client
>   Skipped test-convert-hg-svn.t: missing feature: subversion python bindings
>   Skipped test-convert-mtn.t: missing feature: monotone client (>= 1.0)
>   Skipped test-convert-p4-filetypes.t: missing feature: Perforce server and client
>   Skipped test-convert-p4.t: missing feature: Perforce server and client
>   Skipped test-convert-svn-branches.t: missing feature: subversion python bindings
>   Skipped test-convert-svn-encoding.t: missing feature: subversion python bindings
>   Skipped test-convert-svn-move.t: missing feature: subversion python bindings
>   Skipped test-convert-svn-source.t: missing feature: subversion python bindings
>   Skipped test-convert-svn-startrev.t: missing feature: subversion python bindings
>   Skipped test-convert-svn-tags.t: missing feature: subversion python bindings
>   Skipped test-convert-tla.t: missing feature: GNU Arch tla client
>   Skipped test-debian-packages.t: missing feature: debian build dependencies (run dpkg-checkbuilddeps in contrib/)
>   Skipped test-docker-packaging.t: missing feature: docker support
>   Skipped test-fix-clang-format.t: missing feature: clang-format C code formatter
>   Skipped test-git-interop.t: missing feature: pygit2 Python library
>   Skipped test-lfs-test-server.t#git-server: missing feature: git-lfs test server
>   Skipped test-mac-packages.t: missing feature: OS X packaging tools
>   Skipped test-no-symlinks.t: system supports symbolic links
>   Skipped test-phabricator.t: missing feature: vcr http mocking library
>   Skipped test-releasenotes-formatting.t: missing feature: Fuzzy string matching library
>   Skipped test-releasenotes-merging.t: missing feature: Fuzzy string matching library
>   Skipped test-releasenotes-parsing.t: missing feature: Fuzzy string matching library
>   Skipped test-remotefilelog-bundle2-legacy.t: skipped
>   Skipped test-rhg.t: missing feature: Using the Rust extensions
>   Skipped test-sparse-fsmonitor.t: skipped
>   Skipped test-sparse-revlog.t: missing artifact, run "/<redacted>/hg/tests/artifacts/scripts/generate-churning-bundle.py"
>   Skipped test-sqlitestore.t: missing feature: sqlite3 module is available
>   Skipped test-verify-repo-operations.py: missing feature: allow slow tests (use --allow-slow-tests)
>   Skipped test-wireproto-exchangev2-shallow.t: missing feature: sqlite3 module is available
> 
> Where's the documentation on setting this up correctly with all the required tools? I don't see anything in https://www.mercurial-scm.org/wiki/ContributingChanges .
> 
> I'll install and fix the pyflakes issue.

I don’t think that everyone has all the required tools installed. Even the buildbot didn’t catch the black issue (but it catched the pyflakes issue). Recently I found that `hgext.convert.subversion` was not working on Python 3 at all and nobody realized. More and more builders will be migrated to use Python 3. I think that would be a good chance to install most of the requirements.

Unless you work on C code, JS code or Rust code, I think that installing all Python-specific tools for `tests/test-check-*` is sufficient for most cases. The other failures will hopefully be catched by some buildbot even after it was queued. :)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8721/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8721

To: rdamazio, #hg-reviewers, pulkit
Cc: mjacob, martinvonz, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200711/a4d72c07/attachment-0002.html>