[Updated] D8721: scmutil: allowing different files to be prefetched per revision

rdamazio (Rodrigo Damazio Bovendorp) phabricator at mercurial-scm.org
Sat Jul 11 02:37:16 UTC 2020


rdamazio added inline comments.

INLINE COMMENTS

> mjacob wrote in __init__.py:1124
> I don’t think that everyone has all the required tools installed. Even the buildbot didn’t catch the black issue (but it catched the pyflakes issue). Recently I found that `hgext.convert.subversion` was not working on Python 3 at all and nobody realized. More and more builders will be migrated to use Python 3. I think that would be a good chance to install most of the requirements.
> 
> Unless you work on C code, JS code or Rust code, I think that installing all Python-specific tools for `tests/test-check-*` is sufficient for most cases. The other failures will hopefully be catched by some buildbot even after it was queued. :)

Makes sense.

Thanks for the review, let me know if you need me to do anything else before you can queue this.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8721/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8721

To: rdamazio, #hg-reviewers, pulkit
Cc: mjacob, martinvonz, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200711/1762539f/attachment-0002.html>


More information about the Mercurial-patches mailing list