[Updated] D8697: phases: sparsify phase lists
joerg.sonnenberger (Joerg Sonnenberger)
phabricator at mercurial-scm.org
Mon Jul 13 15:02:23 UTC 2020
joerg.sonnenberger added inline comments.
INLINE COMMENTS
> pulkit wrote in phases.py:152
> These all makes me think that we need a class here. What do you think?
I'm not sure if turning the various lists into predicates or so would actually improve anything. I did change this from the original form to make it easier to reason about them, but otherwise this part is a NFC. Anything more would be much more intrusive and possibly also affect 3rd party extensions like evolve with non-trivial follow-up changes. It doesn't seem to be worth the effort.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8697/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8697
To: joerg.sonnenberger, #hg-reviewers
Cc: pulkit, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200713/8e5ed0e2/attachment-0002.html>
More information about the Mercurial-patches
mailing list