[Updated] D8728: overlayworkingctx: rename misleadingly named `isempty()` method

[mjacob (Manuel Jacob)]

mjacob added inline comments.

INLINE COMMENTS

> martinvonz wrote in context.py:2519-2529
> I feel like it would be better to find better names for these three methods together since they're about the same concept. Maybe simply renaming this one to `isclean()` matches well? The only issue I see is that Mercurial usually skips the "is" prefix and "clean" is both a verb and an adjective, so it's not obvious at first why there's both `clean()` and `isclean()` (people familiar with Mercurial naming might think they're the same). Probably still okay?

To be honest, I didn’t think too hard about this name (at long as it’s more correct as the old name), as the method will become unused and removed a few patches later. If you still think we should rename it for the in-between steps, I’d be fine renaming it.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8728/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8728

To: mjacob, martinvonz, #hg-reviewers
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200713/67212c9e/attachment-0002.html>