[Commented On] D8728: overlayworkingctx: rename misleadingly named `isempty()` method

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Mon Jul 13 20:47:47 UTC 2020


martinvonz added inline comments.

INLINE COMMENTS

> mjacob wrote in context.py:2519-2529
> To be honest, I didn’t think too hard about this name (at long as it’s more correct as the old name), as the method will become unused and removed a few patches later. If you still think we should rename it for the in-between steps, I’d be fine renaming it.

No, that's fine. I had just not realized that it was going away in a later patch.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8728/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8728

To: mjacob, martinvonz, #hg-reviewers
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200713/3bdbad24/attachment-0002.html>


More information about the Mercurial-patches mailing list