[Updated] D8746: rewriteutil: add utility to check whether empty successors should be skipped

[mjacob (Manuel Jacob)]

mjacob added inline comments.

INLINE COMMENTS

> martinvonz wrote in rewriteutil.py:65-72
> I think we usually treat bad config as no config, i.e. use the default ("skip" in this case). You may want to check if I seem to be right about that.

I found cases where an error was raised if an invalid value was used, e.g. https://phab.mercurial-scm.org/diffusion/HG/browse/default/mercurial/merge.py$605

I think that errors should never pass silently. I might sent patches (after the next release) to make it possible to enumerate all legal values in configitems and raise an error if another value was specified.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8746/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8746

To: mjacob, #hg-reviewers, martinvonz, marmoute
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200714/c7a5a04c/attachment-0002.html>