[Commented On] D8686: extdiff: refactor logic which does diff of patches

[Alphare (Raphaël Gomès)]

Alphare added a comment.
Alphare accepted this revision.


  Thanks for refactoring first!

INLINE COMMENTS

> extdiff.py:353
>  
> +def diffpatch(ui, repo, node1a, node2, tmproot, matcher, cmdline, do3way):
> +    template = b'hg-%h.patch'

Could you add a small docstring?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8686/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8686

To: pulkit, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200715/e6bef178/attachment-0002.html>