[Updated] D8688: extdiff: remove unrequired do3way argument to diffpatch()

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Wed Jul 15 15:59:06 UTC 2020


This revision now requires changes to proceed.
Alphare added inline comments.
Alphare requested changes to this revision.

INLINE COMMENTS

> extdiff.py:353
>  
> -def diffpatch(ui, repo, node1a, node2, tmproot, matcher, cmdline, do3way):
> +def diffpatch(ui, repo, node1, node2, tmproot, matcher, cmdline):
>      template = b'hg-%h.patch'

`node1a` -> `node1` should not be in this patch

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8688/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8688

To: pulkit, #hg-reviewers, Alphare
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200715/8cb32214/attachment-0002.html>


More information about the Mercurial-patches mailing list