[Commented On] D8690: extdiff: add some comments in diffrevs()

[Alphare (Raphaël Gomès)]

Alphare added a comment.
Alphare accepted this revision.


  I'm not a big fan of the small-but-non-obvious variable names in this series, but they predate your patches, so maybe for another time.
  Thanks for this series

INLINE COMMENTS

> extdiff.py:423
> +    #   * modified or added from node1b to node2
> +    #     (except file added from node1a to node2 as they were not present in
> +    #     node1a)

Nit: `except files`

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8690/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8690

To: pulkit, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200715/65be3039/attachment-0002.html>