[Updated] D8656: localrepo: load the share source .hg/hgrc also in share-safe mode

[marmoute (Pierre-Yves David)]

This revision now requires changes to proceed.
marmoute added a comment.
marmoute requested changes to this revision.


  I am fine with taking this root (reading source `hgrc` and adding a `nonsharedrc`) as I think it is a better experience overall. **However**, we have to be prepared to drop a large backward compatibility breaking notice when we turn sharesafe on by default, because people relying on the config to not be shared might be up for a surprise.

INLINE COMMENTS

> test-share-safe.t:136
> +  [255]
> +
> +Unsharing works

Can you also add test for the trusting logic ? making sure the other hgrc is untrusted as expected when relevant ?

> test-share-safe.t:140
> +  $ cd ../shared1
>    $ hg unshare

There is apparently an unshare command. Sicne we read the source config, that source config need to be copied in the repository when unsharing. Can you add code and test for this?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8656/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8656

To: pulkit, #hg-reviewers, marmoute
Cc: marmoute, durin42, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200715/d17ffc69/attachment-0002.html>