[Updated] D8633: share: introduce config option to store requires in .hg/store

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Mon Jul 20 17:05:43 UTC 2020


marmoute added inline comments.

INLINE COMMENTS

> marmoute wrote in localrepo.py:537-554
> This looks like a lot of duplicated code, am I missing something ? Could we do less duplication?

I see this is done in D8655 <https://phab.mercurial-scm.org/D8655> thanks !

> pulkit wrote in localrepo.py:3786
> Does not `share` extension implies that `store` is present?

Maybe, can you check ?

In all cases, I would rather make the safe-share requirement consistent from the start. Can we have some code either setup `store` automatically, or reject with some error (whichever solution you prefer).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8633/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8633

To: pulkit, #hg-reviewers, durin42, marmoute
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200720/a745ffaf/attachment-0002.html>


More information about the Mercurial-patches mailing list