[Commented On] D8771: localrepo: only use BOOKMARKS_IN_STORE_REQUIRMENT if we have a store

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Tue Jul 21 08:39:46 UTC 2020


pulkit added a comment.


  Another way we can do is to have a `checkrequirementscompat()` which will check whether we have BOOKMARKS_IN_STORE_REQUIREMENT but not store one and raise error. This one simply drops without any warning. We seems to have following options:
  
  - Drop without any warning
  - Drop with a warning
  - Error
  - Add store requirement (which means BOOKMARKS_IN_STORE_REQUIREMENT implies store requirement)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8771/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8771

To: pulkit, #hg-reviewers
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200721/0fe2b868/attachment-0002.html>


More information about the Mercurial-patches mailing list