[Request] [+ ] D8627: zeroconf: fix non existant formatting in the vendored zeroconf module

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Sat Jun 13 09:07:29 UTC 2020


marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  On Tue Mar 1st 2016 at 09:33:39 timeless decided to wrap long line in
  `hgext/zeroconf/Zeroconf.py`. Doing so, he fat fingered a "%w" instead of a "%s"
  in a string. %w does not exists, 4 year later, pyflakes (rightfully) complains
  about it. So I am fixing it.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D8627

AFFECTED FILES
  hgext/zeroconf/Zeroconf.py

CHANGE DETAILS

diff --git a/hgext/zeroconf/Zeroconf.py b/hgext/zeroconf/Zeroconf.py
--- a/hgext/zeroconf/Zeroconf.py
+++ b/hgext/zeroconf/Zeroconf.py
@@ -1647,7 +1647,7 @@
                     and record.alias == info.name
                 ):
                     if info.name.find(b'.') < 0:
-                        info.name = b"%w.[%s:%d].%s" % (
+                        info.name = b"%s.[%s:%d].%s" % (
                             info.name,
                             info.address,
                             info.port,



To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20200613/5c0535ba/attachment.html>


More information about the Mercurial-patches mailing list