[Request] [+- ] D8668: graft: leverage cmdutil.check_incompatible_arguments() for --no-commit
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Thu Jun 25 22:58:19 UTC 2020
martinvonz created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.
REPOSITORY
rHG Mercurial
BRANCH
default
REVISION DETAIL
https://phab.mercurial-scm.org/D8668
AFFECTED FILES
mercurial/commands.py
tests/test-graft-interrupted.t
CHANGE DETAILS
diff --git a/tests/test-graft-interrupted.t b/tests/test-graft-interrupted.t
--- a/tests/test-graft-interrupted.t
+++ b/tests/test-graft-interrupted.t
@@ -553,15 +553,15 @@
Check reporting when --no-commit used with non-applicable options:
$ hg graft 1 --no-commit -e
- abort: cannot specify --no-commit and --edit together
+ abort: cannot specify both --no-commit and --edit
[255]
$ hg graft 1 --no-commit --log
- abort: cannot specify --no-commit and --log together
+ abort: cannot specify both --no-commit and --log
[255]
$ hg graft 1 --no-commit -D
- abort: cannot specify --no-commit and --currentdate together
+ abort: cannot specify both --no-commit and --currentdate
[255]
Test --no-commit is working:
diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -2986,22 +2986,11 @@
cont = False
if opts.get(b'no_commit'):
- if opts.get(b'edit'):
- raise error.Abort(
- _(b"cannot specify --no-commit and --edit together")
- )
- if opts.get(b'currentuser'):
- raise error.Abort(
- _(b"cannot specify --no-commit and --currentuser together")
- )
- if opts.get(b'currentdate'):
- raise error.Abort(
- _(b"cannot specify --no-commit and --currentdate together")
- )
- if opts.get(b'log'):
- raise error.Abort(
- _(b"cannot specify --no-commit and --log together")
- )
+ cmdutil.check_incompatible_arguments(
+ opts,
+ b'no_commit',
+ [b'edit', b'currentuser', b'currentdate', b'log'],
+ )
graftstate = statemod.cmdstate(repo, b'graftstate')
To: martinvonz, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20200625/46120f68/attachment-0001.html>
More information about the Mercurial-patches
mailing list