[Commented On] D8609: hg-core: add FindRoot operation to find repository root path

[marmoute (Pierre-Yves David)]

marmoute added a comment.


  Pathc looks overall good to me. I have a question regarding the test about some potential tempfile leackage that I woudl like clarified.

INLINE COMMENTS

> find_root.rs:21
> +
> +    /// Curent directory used by FindRoot
> +    ///

(small nits: s/current/current/)

> find_root.rs:69
> +        }
> +        let mut anscestors = current_dir.ancestors();
> +        while let Some(parent) = anscestors.next() {

small nits: s/anscestors/ancestors/

> find_root.rs:90
> +    fn dot_hg_not_found() {
> +        let tmp_dir = tempfile::tempdir().unwrap();
> +        let path = tmp_dir.path();

Do we have to do anything to make sure the temporary directory is deleted at the end of the run ? or are we leaking them ?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8609/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8609

To: acezar, #hg-reviewers
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200609/669cc62a/attachment-0002.html>