[Updated] [+ ] D8620: tests: make it clear what happen when no response entered
khanchi97 (Sushil khanchi)
phabricator at mercurial-scm.org
Tue Jun 9 16:19:56 UTC 2020
khanchi97 updated this revision to Diff 21588.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D8620?vs=21573&id=21588
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8620/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8620
AFFECTED FILES
tests/run-tests.py
tests/test-run-tests.t
CHANGE DETAILS
diff --git a/tests/test-run-tests.t b/tests/test-run-tests.t
--- a/tests/test-run-tests.t
+++ b/tests/test-run-tests.t
@@ -747,7 +747,7 @@
This is a noop statement so that
this test is still more bytes than success.
pad pad pad pad............................................................
- Accept this change? [n]
+ Accept this change? [y/N]
ERROR: test-failure.t output changed
!.
Failed test-failure.t: output changed
@@ -772,7 +772,7 @@
$ echo 'n' | rt -i --view echo
running 2 tests using 1 parallel processes
$TESTTMP/test-failure.t $TESTTMP/test-failure.t.err
- Accept this change? [n]* (glob)
+ Accept this change? [y/N]* (glob)
ERROR: test-failure.t output changed
!.
Failed test-failure.t: output changed
@@ -823,7 +823,7 @@
+ saved backup bundle to $TESTTMP/foo.hg
$ echo 'saved backup bundle to $TESTTMP/foo.hg'
saved backup bundle to $TESTTMP/*.hg (glob)
- Accept this change? [n] ..
+ Accept this change? [y/N] ..
# Ran 2 tests, 0 skipped, 0 failed.
$ sed -e 's,(glob)$,&<,g' test-failure.t
@@ -900,7 +900,7 @@
#endif
#if b
$ echo 2
- Accept this change? [n] .
+ Accept this change? [y/N] .
--- $TESTTMP/test-cases.t
+++ $TESTTMP/test-cases.t#b.err
@@ -5,4 +5,5 @@
@@ -909,7 +909,7 @@
$ echo 2
+ 2
#endif
- Accept this change? [n] .
+ Accept this change? [y/N] .
# Ran 2 tests, 0 skipped, 0 failed.
$ cat test-cases.t
@@ -1285,7 +1285,7 @@
This is a noop statement so that
this test is still more bytes than success.
pad pad pad pad............................................................
- Accept this change? [n] ..s
+ Accept this change? [y/N] ..s
Skipped test-skip.t: missing feature: nail clipper
# Ran 2 tests, 1 skipped, 0 failed.
diff --git a/tests/run-tests.py b/tests/run-tests.py
--- a/tests/run-tests.py
+++ b/tests/run-tests.py
@@ -2260,7 +2260,7 @@
'changes)'
)
else:
- self.stream.write('Accept this change? [n] ')
+ self.stream.write('Accept this change? [y/N] ')
self.stream.flush()
answer = sys.stdin.readline().strip()
if answer.lower() in ('y', 'yes'):
To: khanchi97, #hg-reviewers, marmoute
Cc: pulkit, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200609/afe1f185/attachment-0002.html>
More information about the Mercurial-patches
mailing list