[Commented On] D8563: localrepo: get mergestate via context

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Tue Jun 9 16:46:49 UTC 2020


martinvonz added a comment.


  In D8563#128630 <https://phab.mercurial-scm.org/D8563#128630>, @marmoute wrote:
  
  > Is your concern about the creation of new "independant" wctc (by each call of `repo[None]`) instead of reusing the same wctx for the full operation ?
  
  Yes. I guess I'd rather have the pattern `wctx.mergestate()` indicate that it works with either a `workingctx` or a `overlayworkingctx`, while direct access to `mergestate.read()` indicates that we care about the actual working copy.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8563/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8563

To: durin42, #hg-reviewers
Cc: marmoute, martinvonz, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200609/90a49af8/attachment-0002.html>


More information about the Mercurial-patches mailing list