[Commented On] D8587: metadata: move computation related to files touched in a dedicated module

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.


  In D8587#128844 <https://phab.mercurial-scm.org/D8587#128844>, @marmoute wrote:
  
  > In D8587#128843 <https://phab.mercurial-scm.org/D8587#128843>, @martinvonz wrote:
  >
  >> In D8587#128842 <https://phab.mercurial-scm.org/D8587#128842>, @marmoute wrote:
  >>
  >>> In D8587#128841 <https://phab.mercurial-scm.org/D8587#128841>, @martinvonz wrote:
  >>>
  >>>> Worth mentioning in relnotes? (This has been queued, so that would be a followup.)
  >>>
  >>> I don't think so, what would you mention ?
  >>
  >> We have a section for API changes. This patch affects many functions. (I suppose you might argue that we don't need to mention changes in private APIs (name prefixed by `_`), but these are not all private.)
  >
  > These are private API used by experimental feature. I really do not expect that to affect anyone.
  
  I was thinking mostly about `computechangesetfiles{added,removed}()`, which I think are used even when not using experimental features. We happen to override those, but we also never read the release notes, so it's fine not mention it :)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8587/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8587

To: marmoute, #hg-reviewers, durin42, pulkit
Cc: martinvonz, pulkit, durin42, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200610/58ae4b56/attachment-0002.html>