[Updated] D8596: merge: mark copies in in-memory context when merging

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu Jun 11 17:47:24 UTC 2020


martinvonz added inline comments.
martinvonz planned changes to this revision.

INLINE COMMENTS

> marmoute wrote in mergestate.py:766
> Okay, then it feel like we are going the in wrong direction and breaking the API contract here. For example, why is only part of record update move to apply update ? Does this impact our ability to execute applyupdates in parallel ? etc.
> 
> It would seems much cleaner to call recordupdates on all ctx types, don't it?

Yes, I was also feeling that more and more. We should probably replicate many dirstate methods on workingctx and its subclasses.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8596/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8596

To: martinvonz, #hg-reviewers, marmoute
Cc: marmoute, durin42, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200611/8e291199/attachment-0002.html>


More information about the Mercurial-patches mailing list