[Accepted] D8609: hg-core: add FindRoot operation to find repository root path

[Alphare (Raphaël Gomès)]

Alphare added inline comments.
Alphare accepted this revision.

INLINE COMMENTS

> find_root.rs:10
> +    RootNotFound,
> +    /// The current directory does not exists or permissions are insufficient
> +    /// to get access to it

nit: s/exists/exist

> marmoute wrote in find_root.rs:90
> Do we have to do anything to make sure the temporary directory is deleted at the end of the run ? or are we leaking them ?

https://docs.rs/tempfile/3.1.0/tempfile/struct.TempDir.html#resource-leaking

This is what `tempfile` does, whether that's acceptable is arguable.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8609/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8609

To: acezar, #hg-reviewers, Alphare
Cc: Alphare, marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200615/23dcafe9/attachment-0002.html>