[Commented On] D8631: localrepo: add writerequirements() and route requires writing through it

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Mon Jun 15 15:09:43 UTC 2020


marmoute added a comment.


  "callers directly calling scmutil.writerequires() are **once**
  where" Do you mean "only"  ?
  
  The patch seems to go in the right direction, but the function seems rarely needed enough that is probably worth not making it a method. Could we update the function to take a repo (instead of vs) and act accordingly ?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8631/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8631

To: pulkit, #hg-reviewers
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200615/1f7a6a98/attachment-0002.html>


More information about the Mercurial-patches mailing list