[Commented On] D8640: ui: add option to timestamp status and diagnostic messages
joerg.sonnenberger (Joerg Sonnenberger)
phabricator at mercurial-scm.org
Thu Jun 25 18:54:56 UTC 2020
joerg.sonnenberger added inline comments.
INLINE COMMENTS
> pulkit wrote in ui.py:1737
> Any reason why we are passing `self.showtimestamp` when it can be accessed directly in `self._writemsg`?
_writemsg is also used by other functions, e.g. prompt, getpass etc. I'm not sure we want to timestamp those, they certainly don't apply to my use-case.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8640/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8640
To: joerg.sonnenberger, #hg-reviewers
Cc: pulkit, durin42, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200625/73331a04/attachment-0002.html>
More information about the Mercurial-patches
mailing list