[Commented On] D8640: ui: add option to timestamp status and diagnostic messages

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Mon Jun 29 08:46:55 UTC 2020


pulkit added inline comments.

INLINE COMMENTS

> joerg.sonnenberger wrote in ui.py:1737
> _writemsg is also used by other functions, e.g. prompt, getpass etc. I'm not sure we want to timestamp those, they certainly don't apply to my use-case.

Hm, in that case we can check the `type` in `self_writemsg`.

  if type in set(['status', 'note', 'warning', 'error']):
      ....

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8640/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8640

To: joerg.sonnenberger, #hg-reviewers
Cc: pulkit, durin42, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200629/e3df18d4/attachment-0002.html>


More information about the Mercurial-patches mailing list