[Changed Subscribers] D8486: fastexport: adjust output to be more canonical

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu May 7 15:56:53 UTC 2020


martinvonz added inline comments.

INLINE COMMENTS

> fastexport.py:56
>      timestamp, utcoff = date
> -    tzsign = b"+" if utcoff < 0 else b"-"
> +    tzsign = b"+" if utcoff >= 0 else b"-"
>      if utcoff % 60 != 0:

It looks like this not only changed the treatment of `utcoff == 0` but completely negated it. Is that how it should be? We don't seem to have any tests with non-zero `utcoff`...

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8486/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8486

To: joerg.sonnenberger, #hg-reviewers, marmoute
Cc: martinvonz, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20200507/c5ed555b/attachment.html>


More information about the Mercurial-patches mailing list