[Commented On] D8486: fastexport: adjust output to be more canonical

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Tue May 12 17:08:26 UTC 2020


martinvonz added inline comments.

INLINE COMMENTS

> martinvonz wrote in fastexport.py:56
> It looks like this not only changed the treatment of `utcoff == 0` but completely negated it. Is that how it should be? We don't seem to have any tests with non-zero `utcoff`...

It's a trivial fix that I could of course easily do in flight, but I'd at least like a confirmation first. I'll instead drop this patch for now.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8486/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8486

To: joerg.sonnenberger, #hg-reviewers, marmoute
Cc: martinvonz, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20200512/56f3c217/attachment.html>


More information about the Mercurial-patches mailing list