[Commented On] D8500: tests: use regular POSIX shell

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Thu May 7 14:19:15 UTC 2020


marmoute added a comment.


  Moving to /bin/sh seems fine. Did you run tests for this patch on debian/dash ? (pushing to heptapod should do it)

INLINE COMMENTS

> wait-on-file:26
> -if [ -n "$create" ];
> -then
>      touch "$create"

Unrelated gratuitous change ?

> wait-on-file:31
> -while [ "$timer" -gt 0 ] && [ ! -f "$wait_on" ];
> -do
>      timer=$(( $timer - 1))

same here

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8500/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8500

To: joerg.sonnenberger, #hg-reviewers
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200507/fb8b1156/attachment-0002.html>


More information about the Mercurial-patches mailing list