[Commented On] D8431: upgrade: support upgrade and downgrade from persistent nodemap
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Mon May 11 21:08:33 UTC 2020
durin42 added inline comments.
INLINE COMMENTS
> requirements.txt:150
> +The `nodemap` index (mapping nodeid to local revision number) is persisted on
> +disk. This provides speed benefit (if the associated native code is used. The
> +persistent nodemap is only used for two revlogs: the changelog and the manifest
The parenthetical on this line isn't closed. Should we just drop the opening paren?
> requirements.txt:155
> +Support for this requirement was added in Mercurial 5.5 (released August 2020).
> +Note that as of 5.5, only instalation compiled with the Rust extension will
> +benefit from a speedup. The other instalation will do the necessary work to keep
nit: installations (should be plural, also has typo)
> requirements.txt:156
> +Note that as of 5.5, only instalation compiled with the Rust extension will
> +benefit from a speedup. The other instalation will do the necessary work to keep
> +the index up to date, but will suffer a slowdown.
"Other installations ..."
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8431/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8431
To: marmoute, #hg-reviewers, mharbison72, Alphare, durin42
Cc: durin42, Alphare, mercurial-patches, mharbison72, mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200511/349ccdb4/attachment-0002.html>
More information about the Mercurial-patches
mailing list