[Commented On] D8502: cleanup: avoid extra node/ctx conversions in logcmdutil.diffordiffstat

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Tue May 12 06:21:31 UTC 2020


martinvonz added a comment.


  Mention API change in `relnotes/next`?

INLINE COMMENTS

> commands.py:2492-2495
>      node1, node2 = ctx1.node(), ctx2.node()
>  
>      if reverse:
>          node1, node2 = node2, node1

Can avoid converting to nodes and back by changing this

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8502/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8502

To: durin42, #hg-reviewers
Cc: martinvonz, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200512/f977e27b/attachment-0002.html>


More information about the Mercurial-patches mailing list