[Updated] D8525: phabricator: avoid passing None to pycompat.fsdecode

[Phabricator]

Closed by commit rHG11592ce6a711: phabricator: avoid passing None to pycompat.fsdecode (authored by Steve Fink <sfink at mozilla.com>).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D8525?vs=21387&id=21419

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8525/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8525

AFFECTED FILES
  hgext/phabricator.py

CHANGE DETAILS

diff --git a/hgext/phabricator.py b/hgext/phabricator.py
--- a/hgext/phabricator.py
+++ b/hgext/phabricator.py
@@ -238,8 +238,8 @@
 
     def decorate(fn):
         def inner(*args, **kwargs):
-            cassette = pycompat.fsdecode(kwargs.pop('test_vcr', None))
-            if cassette:
+            if kwargs.get('test_vcr'):
+                cassette = pycompat.fsdecode(kwargs.pop('test_vcr'))
                 import hgdemandimport
 
                 with hgdemandimport.deactivated():



To: sfink, #hg-reviewers, pulkit
Cc: Kwan, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200518/332d963b/attachment-0002.html>