[Commented On] D8552: fix: use context to fetch mergestate instead of loading it directly

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Tue May 19 19:17:33 UTC 2020


durin42 added a comment.


  In D8552#127895 <https://phab.mercurial-scm.org/D8552#127895>, @martinvonz wrote:
  
  > I think I'd prefer to leave code that doesn't use `overlayworkingctx` unchanged. I don't see any reason to get the merge state from the context if we know that the context is a regular `workingctx`.
  
  I'd rather it was globally-consistent that if you need a mergestate, you load it via a context, so that more code will implicitly be right for in-memory operations.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8552/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8552

To: durin42, #hg-reviewers
Cc: martinvonz, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200519/6bc521ab/attachment-0002.html>


More information about the Mercurial-patches mailing list