[Changed Subscribers] D8586: files: speed up `hg files` when no flags change display

joerg.sonnenberger (Joerg Sonnenberger) phabricator at mercurial-scm.org
Tue May 26 12:57:16 UTC 2020


joerg.sonnenberger added inline comments.

INLINE COMMENTS

> cmdutil.py:2760
> +        for f in ctx.matches(m):
> +            buf += fmt % uipathfn(f)
> +            if len(buf) > 5000:

The normal idiom for batches uses a list and a single join at time of writing. Not sure if there are repositories where we care about the size of the temporary buffer enough to flush it in the middle.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8586/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8586

To: valentin.gatienbaron, #hg-reviewers
Cc: joerg.sonnenberger, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200526/7795b70b/attachment-0002.html>


More information about the Mercurial-patches mailing list