[Updated] D8586: files: speed up `hg files` when no flags change display

[marmoute (Pierre-Yves David)]

This revision now requires changes to proceed.
marmoute added a comment.
marmoute requested changes to this revision.


  The overall idea seems good, but @joerg.sonnenberger feedback sound probably be taken in account.

INLINE COMMENTS

> joerg.sonnenberger wrote in cmdutil.py:2760
> The normal idiom for batches uses a list and a single join at time of writing. Not sure if there are repositories where we care about the size of the temporary buffer enough to flush it in the middle.

+1 we should use a list here, there are optimisation around such string concatenation but I would not could on it.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8586/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8586

To: valentin.gatienbaron, #hg-reviewers, marmoute
Cc: marmoute, joerg.sonnenberger, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20200526/1437ec64/attachment-0002.html>