[Commented On] D9284: purge: move extension into core mercurial

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Mon Nov 9 00:29:42 UTC 2020


mharbison72 added a comment.


  Should this extension be added to `mercurial.extensions._builtin` like color, progress and shelve?  (I see pager isn't, so I'm not clear what this list does.)
  
  The other thought I had was should `extensions.purge=!` in the config disable the command (due to the potential footgun)?  I thought a similar config would disable the builtin color or pager, but some experimenting seems to show that isn't the case, so IDK where I got that idea.  I don't feel strongly about this, and a followup would be fine if anyone else thinks it's a safety factor with merit.
  
  I definitely like the idea of not being interactive, so that scripts can more easily purge.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9284/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9284

To: valentin.gatienbaron, #hg-reviewers
Cc: mharbison72, joerg.sonnenberger, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20201109/31c7ba28/attachment-0002.html>


More information about the Mercurial-patches mailing list