[Updated] D9309: errors: set detailed exit code to 100 for some remote errors

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri Nov 13 07:59:38 UTC 2020


martinvonz added inline comments.

INLINE COMMENTS

> mharbison72 wrote in test-clone.t:621
> I'm surprised this is a considered a remote error.  Maybe it's related to the sniffing for HttpError or URLError in the exception handler?  (I'm fine with this if you are- maybe there's no way to distinguish from a remote error).

I agree.  I spent a bit of time trying to convert the errors at a lower level (in `keepalive.py`) but it seems hard to tell them apart even there. So I'd say it's probably not worth it.

I insert D9318 <https://phab.mercurial-scm.org/D9318> before this patch to clean up a little.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9309/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9309

To: martinvonz, #hg-reviewers
Cc: mharbison72, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20201113/dfacce0d/attachment-0002.html>


More information about the Mercurial-patches mailing list